Files
screen_cast/src/network/udp_transport.cpp
T
fegger 10870bc6c9 feat(app): implement Phase 5 local UDP sender->receiver loopback
Wire the first end-to-end pipeline: capture -> encode -> packetize ->
UDP -> depacketize -> decode -> render.

- UdpRtpTransport: raw POSIX UDP sockets (IPv4 via getaddrinfo), a
  receive jthread woken by socket close on stop; port 0 skips binding
  so the sender uses an OS-assigned source port. ASIO stays deferred
  to the signaling phase per ARCHITECTURE.md.
- SdlRenderer: SDL3 window/renderer with RGBA texture upload; the
  texture is recreated on resolution change. RendererFactory now
  returns RendererResult so SDL init failures carry a message,
  mirroring the codec/capture error patterns.
- screencast binary: parse_cli plus SenderPipeline/ReceiverPipeline
  per the app scaffolds; the sender creates its encoder once capture
  reports real dimensions, the receiver keeps a bounded 3-frame queue
  to hold latency down and renders on its own thread until the window
  closes. cli argv signature fixed to 'const char* const*' so main's
  argv converts implicitly.
- Encoder: drop AV_CODEC_FLAG_GLOBAL_HEADER so libx264 repeats SPS/PPS
  in-band at each keyframe -- the receiver decodes from the bitstream
  alone, which also makes mid-stream joins and later PLI recovery
  work without out-of-band parameter negotiation. The round-trip test
  now exercises exactly that path.
- tests: new udp-loopback integration test pushes synthetic frames
  through a real localhost socket and decodes 10/10 frames with the
  right dimensions; valgrind clean (loopback + codec). meson test 4/4.

Manual validation on the desktop (receiver window shows the captured
desktop) is documented in docs/RUNBOOK.md.
2026-09-07 11:02:40 +02:00

164 lines
5.0 KiB
C++

#include "screencast/network/transport.h"
#include <arpa/inet.h>
#include <netdb.h>
#include <netinet/in.h>
#include <sys/socket.h>
#include <unistd.h>
#include <array>
#include <atomic>
#include <cstring>
#include <mutex>
#include <optional>
#include <string>
#include <thread>
namespace sc {
namespace {
constexpr int kInvalidSocket = -1;
// A UDP datagram cannot exceed 64 KiB on IPv4; one buffer fits any RTP
// packet the receiver will ever see.
constexpr std::size_t kReceiveBufferSize = 65536;
std::optional<sockaddr_in> resolve_ipv4(const Endpoint& endpoint) {
addrinfo hints{};
hints.ai_family = AF_INET;
hints.ai_socktype = SOCK_DGRAM;
addrinfo* result = nullptr;
const std::string port = std::to_string(endpoint.port);
const char* node = endpoint.address.empty() ? nullptr : endpoint.address.c_str();
if (getaddrinfo(node, port.c_str(), &hints, &result) != 0) {
return std::nullopt;
}
std::optional<sockaddr_in> address;
if (result != nullptr && result->ai_family == AF_INET && result->ai_addrlen >= sizeof(sockaddr_in)) {
sockaddr_in resolved{};
std::memcpy(&resolved, result->ai_addr, sizeof(sockaddr_in));
address = resolved;
}
freeaddrinfo(result);
return address;
}
} // namespace
class UdpRtpTransport final : public RtpTransport {
public:
UdpRtpTransport() = default;
~UdpRtpTransport() override {
stop();
}
UdpRtpTransport(const UdpRtpTransport&) = delete;
UdpRtpTransport& operator=(const UdpRtpTransport&) = delete;
bool start(const Endpoint& local_endpoint, ReceiveCallback on_receive) override {
if (running_.load()) {
return false;
}
socket_ = ::socket(AF_INET, SOCK_DGRAM, 0);
if (socket_ < 0) {
return false;
}
int reuse = 1;
(void)::setsockopt(socket_, SOL_SOCKET, SO_REUSEADDR, &reuse, sizeof(reuse));
// A zero port skips binding: the OS picks the source port on send.
if (local_endpoint.port != 0) {
const std::optional<sockaddr_in> address = resolve_ipv4(local_endpoint);
if (!address.has_value()) {
(void)::close(socket_);
socket_ = kInvalidSocket;
return false;
}
if (::bind(socket_, reinterpret_cast<const sockaddr*>(&*address), sizeof(*address)) < 0) {
(void)::close(socket_);
socket_ = kInvalidSocket;
return false;
}
}
running_.store(true);
receive_thread_ = std::jthread([this, callback = std::move(on_receive)]() mutable { receive_loop(callback); });
return true;
}
bool send(const RtpPacket& packet) override {
if (!running_.load() || !has_peer_.load()) {
return false;
}
const std::vector<std::byte> bytes = packet.serialize();
if (bytes.empty()) {
return false;
}
sockaddr_in peer{};
{
// Snapshot the peer so set_peer() can be called concurrently.
std::lock_guard lock(peer_mutex_);
peer = peer_;
}
const ssize_t sent =
::sendto(socket_, bytes.data(), bytes.size(), 0, reinterpret_cast<const sockaddr*>(&peer), sizeof(peer));
return sent == static_cast<ssize_t>(bytes.size());
}
void set_peer(const Endpoint& peer) override {
const std::optional<sockaddr_in> address = resolve_ipv4(peer);
if (!address.has_value()) {
return;
}
std::lock_guard lock(peer_mutex_);
peer_ = *address;
has_peer_.store(true);
}
void stop() override {
if (!running_.exchange(false)) {
return;
}
if (socket_ >= 0) {
(void)::shutdown(socket_, SHUT_RDWR);
(void)::close(socket_);
socket_ = kInvalidSocket;
}
// Closing the socket unblocks recvfrom; joining happens implicitly
// when the jthread assignment destroys the previous thread.
receive_thread_ = std::jthread{};
}
private:
void receive_loop(ReceiveCallback& callback) {
std::array<std::byte, kReceiveBufferSize> buffer{};
while (running_.load()) {
const ssize_t received = ::recvfrom(socket_, buffer.data(), buffer.size(), 0, nullptr, nullptr);
if (received <= 0) {
continue; // closed socket while running_ still true, or error
}
const std::optional<RtpPacket> packet =
RtpPacket::parse(std::span{buffer.data(), static_cast<std::size_t>(received)});
if (packet.has_value()) {
callback(*packet);
}
}
}
int socket_ = kInvalidSocket;
std::atomic<bool> running_{false};
std::atomic<bool> has_peer_{false};
std::mutex peer_mutex_;
sockaddr_in peer_{};
std::jthread receive_thread_;
};
std::unique_ptr<RtpTransport> RtpTransportFactory::create() {
return std::make_unique<UdpRtpTransport>();
}
} // namespace sc